Use correct number of dimension names in Xspress3ExternalFileReference #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rated in databroker
danielballan
requested changes
Jan 31, 2024
Author
|
@mrakitin Can you review and merge this for me, please? |
mrakitin
reviewed
Mar 16, 2024
Member
mrakitin
left a comment
mrakitin
left a comment
There was a problem hiding this comment.
Looks good overall, just added a couple of non-blocking comments.
danielballan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an error that was identified in bluesky/databroker#793 during tests for the Data Security project at SRX.
The error was tracked from tiled, back to databoker and last here where the default information of the dimensions of an Xspress3ExternalFileReference was being saved in a BlueSky document and this was causing an error while using this information and data to create an array in an xarray.Dataset.
The definition of
dim_namewas modified which considers the correct dimensions of the array and fixes the error when xarrays are generated in databroker.The original use of
dim_namewas kept for cases where backwards compatibility is necessary.